[chore] change config tests to unmarshal only the config for that component #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponent The main motivation for this is to allow components (including tests) to not depend on the "service" configuration and be reusable without the otelcol service. Signed-off-by: Bogdan <[email protected]>
bogdandrutu
force-pushed
the
confmaptest
branch
from
99f3f7e to
a3286b4
Compare
Codecov Report
@@ Coverage Diff @@
## main #5895 +/- ##
==========================================
- Coverage 91.56% 91.46% -0.11%
==========================================
Files 195 195
Lines 11915 11915
==========================================
- Hits 10910 10898 -12
- Misses 795 807 +12
Partials 210 210
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/cc @mx-psi since you asked for decoupling more of the components. |
mx-psi
approved these changes
Aug 11, 2022
4 tasks
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for this is to allow components (including tests) to not depend on the "service" configuration and be reusable without the otelcol service.
If we agree on this we should do the same in contrib components.
Signed-off-by: Bogdan [email protected]